build: infer cargo mode with gyp var build_type directly #61354
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Review requested:
|
nodejs-github-bot
added
build
cjihrig
approved these changes
Jan 13, 2026
github-actions
bot
removed
the
request-ci
Collaborator
legendecas
added
author ready
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in d1e26f6 |
aduh95
pushed a commit
that referenced
this pull request
Jan 20, 2026
PR-URL: #61354 Refs: https://github.com/nodejs/gyp-next/blob/main/docs/InputFormatReference.md#processing-order Reviewed-By: Colin Ihrig <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GYP configurations don't work well with variable expansions as the configuration
is merged after the variable expansion.
Refs: #61327 (comment)
Refs: https://github.com/nodejs/gyp-next/blob/main/docs/InputFormatReference.md#processing-order